Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add slack source #3148

Merged
merged 16 commits into from
May 11, 2024
Merged

feat: add slack source #3148

merged 16 commits into from
May 11, 2024

Conversation

gitcommitshow
Copy link
Collaborator

@gitcommitshow gitcommitshow commented Feb 29, 2024 •
edited
Loading

What are the changes introduced in this PR?

Adds Slack source transform

Research doc - https://www.notion.so/rudderstacks/Slack-Source-integration-119cd4bd3d9c466fb875c10dc77fc719?pvs=4

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

No

Any new dependencies introduced with this change?

No

Any new generic utility introduced or modified. Please explain the changes.

No

Any technical or performance related pointers to consider with the change?

N

@coderabbitai review

Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@gitcommitshow gitcommitshow requested a review from a team as a code owner February 29, 2024 19:23
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 29, 2024 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@gitcommitshow gitcommitshow marked this pull request as draft February 29, 2024 19:25
@gitcommitshow gitcommitshow self-assigned this Feb 29, 2024
@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3148/test-report.html

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.88%. Comparing base (be0e5f5) to head (d16752b).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/v0/sources/slack/transform.js 89.58% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3148   +/-   ##
========================================
  Coverage    87.87%   87.88%           
========================================
  Files          558      560    +2     
  Lines        30062    30126   +64     
  Branches      7194     7212   +18     
========================================
+ Hits         26418    26477   +59     
+ Misses        3341     3318   -23     
- Partials       303      331   +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitcommitshow gitcommitshow marked this pull request as ready for review March 4, 2024 11:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

koladilip
koladilip previously approved these changes Mar 14, 2024
View reviewed changes
yashasvibajpai
yashasvibajpai previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@yashasvibajpai yashasvibajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we adding tests in this PR?

@yashasvibajpai
Copy link
Contributor

@shrouti1507 added you too for a review if time permits

@gitcommitshow
Copy link
Collaborator Author

Are we adding tests in this PR?

I wrote some tests on local but facing difficulties in verifying those on my local machine. Need suggestions on how to move forward.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@gitcommitshow gitcommitshow dismissed stale reviews from yashasvibajpai and koladilip via ea655bf April 27, 2024 17:02
@gitcommitshow gitcommitshow requested review from sivashanmukh and a team as code owners April 27, 2024 17:02
yashasvibajpai
yashasvibajpai previously approved these changes Apr 29, 2024
View reviewed changes
test/integrations/sources/slack/data.ts Show resolved Hide resolved
@gitcommitshow gitcommitshow requested a review from krishna2020 May 2, 2024 08:59
@gitcommitshow gitcommitshow requested a review from krishna2020 May 9, 2024 16:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gitcommitshow gitcommitshow merged commit 3cbb011 into develop May 11, 2024
17 checks passed
@gitcommitshow gitcommitshow deleted the feat.slack-source branch May 11, 2024 13:06
@gitcommitshow
Copy link
Collaborator Author

Tested on prod. This is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@krishna2020 krishna2020 krishna2020 approved these changes

@koladilip koladilip koladilip left review comments

@chandumlg chandumlg Awaiting requested review from chandumlg chandumlg is a code owner automatically assigned from rudderlabs/integrations

@saikumarrs saikumarrs Awaiting requested review from saikumarrs saikumarrs is a code owner automatically assigned from rudderlabs/integrations

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@shreya-yadu shreya-yadu Awaiting requested review from shreya-yadu

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees

@gitcommitshow gitcommitshow

Labels
new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gitcommitshow @devops-github-rudderstack @yashasvibajpai @krishna2020 @koladilip